Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add muesli/termenv #3685

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Conversation

mjarkk
Copy link
Contributor

@mjarkk mjarkk commented Jul 30, 2021

So lately i have used this list to get another text color library for lazygit with support for RGB colors, sadly there seems to be only one library in here that is not a logger and has RGB text color support (https://github.com/gookit/color) sadly that library has a lot of problems for my use case:

  • No single interface for switching between 16-color (4-bit), 256-color (8-bit) and true color (24-bit, RGB) (so i needed to write at least 100 lines for a general abstraction)
  • A lot of chinese in it's docs and source code
  • Seems to miss a lot of helper functions for advanced usage
    Github just recommended https://github.com/muesli/termenv and if only that library was in this list because it solves all the problems from above and supports all the terminal color outputs just fine and thus would have saved me lots of time

Please provide package links to:

The code coverage is not great but i hope i can convince you with the intro

Make sure that you've checked the boxes below before you submit PR:
not every repository (project) will fit into every option, but most projects should

  • I have added my package in alphabetical order.
  • I have an appropriate description with correct grammar.
  • I know that this package was not listed before.
  • I have added pkg.go.dev link to the repo and to my pull request.
  • I have added coverage service link to the repo and to my pull request.
  • I have added goreportcard link to the repo and to my pull request.
  • I have read Contribution guidelines, maintainers note and Quality standard.

Thanks for your PR, you're awesome! 👍

@avelino
Copy link
Owner

avelino commented Jul 30, 2021

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body links content check:

  • godoc.org or pkg.go.dev: True
  • goreportcard.com: True
  • coverage: True

your project is about to be approved, it's under revision, it may take a few days

@phanirithvij
Copy link
Collaborator

The coverage is < 80%.

@mjarkk
Copy link
Contributor Author

mjarkk commented Jul 31, 2021

@phanirithvij yes I know but did you even read the pr?
This library can save a lot of people a lot of time.

@phanirithvij
Copy link
Collaborator

phanirithvij commented Jul 31, 2021

@mjarkk yes I did read the PR and I also created an issue in that repo to try get the code coverage up.
If you truly believe this is a useful library and will help a lot of people, I think it would be best to wait for it to be well tested before suggesting it to people. That is why the quality standards exist.

And yes, I do agree with you that it is useful.

If you are able to, you can move it forward by making a PR in that repo and increase the code coverage.

@phanirithvij
Copy link
Collaborator

Seems like it's hard to do integration tests with terminal. muesli/termenv#43 (comment)

@phanirithvij phanirithvij merged commit d89b494 into avelino:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants